gh-85267: Improvements to inspect.signature __text_signature__ handling#98796
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes a couple related changes to inspect.signature's behaviour when parsing a signature from
__text_signature__.First,
inspect.signatureis documented as only raising ValueError or TypeError. However, in some cases, we could raise RuntimeError. This PR changes that, thereby fixing #83685.(Note that the new ValueErrors in RewriteSymbolics are caught and then reraised with a message)
Second,
inspect.signaturecould randomly drop parameters that it didn't understand (corresponding toreturn Nonein thepfunction). This is the core issue in #85267. I think this is very surprising behaviour and it seems better to fail outright.Third, adding this new failure broke a couple tests. To fix them (and to e.g. allow
inspect.signature(select.epoll.register)as in #85267), I add constant folding of a couple binary operations to RewriteSymbolics.(There's some discussion of making signature expression evaluation arbitrary powerful in #68155. I think that's out of scope. The additional constant folding here is pretty straightforward, useful, and not much of a slippery slope)
Fourth, while #85267 is incorrect about the cause of the issue, it turns out if you had consecutive newlines in
__text_signature__, you'd gettokenize.TokenError.Finally, the
if name is invalid:code path was dead, sinceparse_namenever returnedinvalid.